-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make rn core copy the state on cloning the shadow tree #41101
feat: make rn core copy the state on cloning the shadow tree #41101
Conversation
@WoLewicki Could you please add one or more verify steps to the test steps? What is the expected result or behaviour after scrolling, and/or after sending the edited message? |
@WoLewicki bump |
@akinwale I added a video and more comprehensive steps to reproduce. If you check on |
Reviewer Checklist
Screenshots/VideosAndroid: Native41101-android-native.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
🚀 Deployed to staging by https://github.com/AndrewGable in version: 1.4.74-0 🚀
|
🚀 Deployed to production by https://github.com/chiragsalian in version: 1.4.74-6 🚀
|
Details
PR fixing the behavior of losing the state when cloning the tree inside RN core. It is connected with
MarkdownCommitHook
cloning the tree on commit, and RN not copying the proper state afterwards. It makes theScrollView
lose the information of being scrolled. It resolves in this issue: #40723. With this patch we copy the state making the button behave correctly.Fixed Issues
$ #40723
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
video.mp4
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop